FIX Detect COMPOSER_ROOT_VERSION on push events #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11
Push events to forked repos are causing
COMPOSER_ROOT_VERSION
to be something likedev-pulls/1.10/module-standards
, instead of1.10
This causes issues if the module being tested is included as part of composer requiring silverstripe/installer
example
- silverstripe/recipe-cms 4.10.x-dev requires silverstripe/versioned-admin 1.10.x-dev -> satisfiable by silverstripe/versioned-admin[1.10.x-dev] from composer repo (https://repo.packagist.org/) but silverstripe/versioned-admin is the root package and cannot be modified.
This PR makes a go at better detection of
COMPOSER_ROOT VERSION
The regex can be manually validated with